Release Magisk v26.4 · topjohnwu/Magisk
github.com
[MagiskBoot] Don't pad zeros if signed boot image is larger [MagiskPolicy] Fix genfscon and filename_trans [MagiskPolicy] Fix bug in libsepol [Zygisk] Fix and simplify file descriptor sanitization ...
  • [MagiskBoot] Don’t pad zeros if signed boot image is larger
  • [MagiskPolicy] Fix genfscon and filename_trans
  • [MagiskPolicy] Fix bug in libsepol
  • [Zygisk] Fix and simplify file descriptor sanitization logic
  • [App] Prevent OOM when patching AP tarfiles
  • [App] Fix bug in device configuration detection
  • [Daemon] Fix certificate parsing of APKs
  • [General] Fix logging errors from C++ code being ignoredq
    • TWeaK@lemm.eeEnglish
      3·
      1 year ago

      Yeah they do generally, and I can install and run a custom recovery (Orange Fox, had more luck with that on my device than TWRP). When I’m in recovery, I can see all the root storage, I can see all the installed apps, but sdcard just has Fox’s log folder while storage has a bunch of folders with encrypted names. I think maybe it’s the ROM specifically (DivestOS) that’s doing some extra encryption, I’m not sure. In any case, I struggle to flash things because of this, sometimes I’ve had to stick with the stock LineageOS recovery and sideload to get Magisk on.

      Maybe with more tinkering I could figure out the issue, but I don’t really have the time so much anymore.

      • nerdschleife@lemm.eeEnglish
        4·
        1 year ago

        I faced this without an OS installed, my storage wasn’t encrypted. Something to do with orangefox, because twrp worked normally.

        • TWeaK@lemm.eeEnglish
          2·
          1 year ago

          Maybe, I had OrangeFox working on other ROMs, might give TRWP a try again. Tbh it could just be my phone (Poco F3), never really been able to get things working smoothly, eg backup and restore at recovery level.

          • nerdschleife@lemm.eeEnglish
            2·
            1 year ago

            Plus Google doing all they can to make rooting harder. Beginning to think it isn’t worth it anymore. I definitely need it now to get rid of the horrid MIUI skin, but for my next phone I might just go for one with a stockish skin and keep it as is.

            • TWeaK@lemm.eeEnglish
              1·
              1 year ago

              In my opinion you should just rip the bandaid off and go without Google Play Services. I haven’t had it installed for a long time, if you set Magisk to Zygisk mode with and set banking apps or whatever else on the DenyList then they will likely work. I haven’t actually found any apps that truly require Google Play Services in a long while, although I generally try not to use most apps where I can avoid them.

              The one downside might be that you can’t use Google Pay, but I question whether you should’ve been using that to begin with.

              MIUI is definitely cancer, though usually you can get away from it. It feels proper dodgy using their Windows software to unlock the bootloader, though - I’m sure if I scan the files in 5-10 years’ time I’ll find a bunch of exploits that are currently zero day. That’s what happened with my Baofeng radios, anyway.

        • TWeaK@lemm.eeEnglish
          2·
          1 year ago

          Maybe, but it looks the same as the LineageOS one, and doesn’t have any functionality really beyond ADB Sideload. At least, that’s all I’ve ever had for my alioth version.

          • nerdschleife@lemm.eeEnglish
            1·
            1 year ago

            Plus Google doing all they can to make rooting harder. Beginning to think it isn’t worth it anymore. I definitely need it now to get rid of the horrid MIUI skin, but for my next phone I might just go for one with a stockish skin and keep it as is.