You must log in or register to comment.
“You aren’t writing enough lines of code!” - Management
I’m a bit disappointed there isn’t a call to GetBooleanValue in there
If this were a Node module, I wouldn’t even be surprised.
WTAF? Is this written by a hallucinating AI?
Straight from the famous book “Making LOCs for Dummies”
I misread it as CompareBolians. No more Star Trek memes for me today.
Many Bolians died bringing us this information.
Clearly it should be
return orig == valDuh
To match the current behavior it should be orig != val
Don’t do OOP kids
That’s not OO code
Still good advice, though.
Not even once
This is your brain when you OD on OOP.
There’s literally nothing related to OOP in this snippet.
You’re right, this is just not oop AT ALL.
For the correct OOP solution, you would need consider whether this can be thought of as a kind of stateless leaf method, and therefore implement it as an abstract (singleton) factory, but on the other hand, if you’re using a context object with the registry pattern, you should probably do this properly with IoC containers. Of course, if your object graph isn’t too complex or entangled, you could always just do constructor injection but you risk manging your unit tests, so I would go cautiously if I were looking in that direction.
I love how OOP devolves into shoving code up it’s own ass.
Shouldn’t there be a call to the boolean comparison microservices server in there somewhere? Also, we should consider the possibility that booleans and their operators could be overloaded to do something else entirely. We might need a server farm to handle all of the boolean comparison service requests.
You’re so right, I didn’t think of that. Maybe I’m not cut out to be a manager in IT.
I was just thinking it needed more factories
What about a factory for the factories! There’s nothing more efficient than a tool making tool making tool.
Management: Gee whiz, we really have no idea how to gauge productivity to decide who gets promoted. We could manage. Or, better, we could just have someone write a script that pulls info from git on how many lines of code each person has written.
Programmers:
I promote based on lines of code removed.
Which is all the easier to do when you start off with a higher number…
I love deleting code, including my own, more than writing code. That’s a killer metric imo.
I quit based on idiotic metrics
Ah, the idiotic idiotic metric metric.
Are you 14?
I’m sure it was meant as a joke, not a serious criticism.
I think we can all agree that managers who have no idea what’s important absolutely suck
Wait areBooleanEqual returns false when they are equal?
That’s not even the worst part. What the fuck does a function named Compare_anything do? Does it return anything? It sounds like nothing but a side effect.
The unnecessary and confusing functions are horrible, yes, but I’d still say that the fact that they’re wrong is the “worst” part.
That’s enough chit-chat, nerds. Back to work.
- Management
Usually comparison functions are supposed to return an integer and are usually useful for sorting. However this one returns a bool so it’s both useless and terribly named.
yesn’t
This actually made me laugh, thank you.
Two wrongs don’t make a right, but sometimes in programming, two bugs can cancel each other out.
Whoever wrote this is more than capable of using it incorrectly.
Don’t forget the invocation
if (CompareBooleans(a, b) == true)if (CompareBooleans(CompareBooleans(a, b), true))I don’t like this thread anymore :(
No, no, this is actually the only correct code in the thread.
that… actually works…
elseif(CompareBooleans(b,a) != false)
Is this part of Elons “How many lines of choice have you written?” interview?
Those are rookie lines of code numbers right there.
I would have done it without the==internal static bool AreBooleansEqual(bool orig, bool val) { if(orig) { if(val) return false return true } if(val) return true return false }Don’t know why their code returns false when they are equal but I’m not going to dig through old code to refactor to use true instead of false.
Put more curly brackets around your if (val) true statement for 4 more lines, put elses in there for more lines even.
I should have created a local variable to store the result variable and return after the if statements. I just couldn’t help to make it look partially nice. My brain just doesn’t think at this high caliber of LOC optimizations.
New optimized LOC version:
internal static bool AreBooleansEqual(bool orig, bool val) { bool result; if(orig) { if(val) { result = false; } else { result = true; } } else { if(val) { result = true; } else { result = false; } } return result; }My previous LOC: 12
New LOC version: 27
you can also use XOR operation
return (X || Y) && !(X && Y)I was debating on bitwise operations, but decided on super basic if statements which I think the compiler would optimize, happy to see the logical operation form too
